Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/5236#issuecomment-90713134
@ilganeli I took a quick look at this and I believe this does not currently
handle backward compatibility. For instance,
`spark.storage.blockManagerSlaveTimeoutMs` used to take in the string "5000",
but now I have to do "5s" otherwise it will throw an exception. The bigger
issue is that it's very strange to see a config ending with `Ms` to accept a
value "5s" or "20ms". I think this patch does only half of what I intended, and
the other half must accompany this half.
However, to deprecate all these configs is currently a very verbose
process. This is why I opened
[SPARK-5933](https://issues.apache.org/jira/browse/SPARK-5933), which I
actually see as a prerequisite before we solve either SPARK-5931 or SPARK-5932.
For these reasons I would suggest that we put this PR on hold for now. I
definitely do want to merge some variant of the changes here, but I don't think
there's currently a great way forward yet.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
