Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/5236#discussion_r28000465
--- Diff: core/src/main/scala/org/apache/spark/HeartbeatReceiver.scala ---
@@ -62,14 +62,18 @@ private[spark] class HeartbeatReceiver(sc: SparkContext)
// "spark.network.timeout" uses "seconds", while
`spark.storage.blockManagerSlaveTimeoutMs` uses
// "milliseconds"
- private val executorTimeoutMs =
sc.conf.getOption("spark.network.timeout").map(_.toLong * 1000).
- getOrElse(sc.conf.getLong("spark.storage.blockManagerSlaveTimeoutMs",
120000))
+ private val networkTimeoutS =
Utils.timeStringAsS(sc.conf.get("spark.network.timeout", "120s"))
+ private val executorTimeoutMs = Utils.timeStringAsMs(
+ sc.conf.get("spark.storage.blockManagerSlaveTimeoutMs",
+ s"${networkTimeoutS}s"))
--- End diff --
this doesn't preserve the order. Before `spark.network.timeout` takes
higher precedence, and if that's not defined we default to
`spark.storage.blockManagerSlaveTimeoutMs`, which is deprecated IIRC. Currently
the priority is inverted.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
