Github user ilganeli commented on the pull request:
https://github.com/apache/spark/pull/5396#issuecomment-90731048
Mark - your point is valid. However, then we we get enormous monolithic
functions that are near impossible to read , comprehend, or debug without
specialized knowledge. The counterpoint I'd make is that any changes throughout
DAGScheduler are necessarily faced with heavy scrutiny, I'd argue that
opportunity for misuse of the now visible functions is unlikely.
Moreover, because their functionality is now much clearer, it will be
easier to reason about any subsequent changes and write cleaner more stable
code that uses these pieces effectively.
Sent with Good (www.good.com)
-----Original Message-----
From: Mark Hamstra
[[email protected]<mailto:[email protected]>]
Sent: Tuesday, April 07, 2015 04:16 PM Eastern Standard Time
To: apache/spark
Cc: Ganelin, Ilya
Subject: Re: [spark] [SPARK-6746B] Refactor large functions in DAGScheduler
to improve readibility (#5396)
Ok, in looking further, I see that I'm going to have a more general problem
with this PR. I can't see exposing carefully nested and scoped portions of
functions to the rest of the DAGScheduler as a good thing. Things are defined
and visible where they make sense and are needed, and are intentionally not
available elsewhere. To me, exposing additional interfaces to all of the
DAGScheduler makes it more complicated to figure out how and when the various
pieces should be used, not less.
â
Reply to this email directly or view it on
GitHub<https://github.com/apache/spark/pull/5396#issuecomment-90717805>.
________________________________________________________
The information contained in this e-mail is confidential and/or proprietary
to Capital One and/or its affiliates. The information transmitted herewith is
intended only for use by the individual or entity to which it is addressed. If
the reader of this message is not the intended recipient, you are hereby
notified that any review, retransmission, dissemination, distribution, copying
or other use of, or taking of any action in reliance upon this information is
strictly prohibited. If you have received this communication in error, please
contact the sender and delete the material from your computer.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
