Github user ilganeli commented on the pull request:
https://github.com/apache/spark/pull/5396#issuecomment-90987956
@markhamstra I've moved the helper functions into the scope of the
functions that use them and added clarifying comments to separate the helper
functions from the code that uses them. The major gain that I see here is that
now process flow for the complex functions is much easier to understand, e.g.
in ```handleTaskCompletion``` the operational logic is now condensed to a
concise set of case statements and the handling of each case is abstracted to
the individual functions.
By modularizing the code, it's now easier to reason about the operation of
the DAGScheduler. I agree with the need to minimize uninformed modification of
this code but I think even core committers could benefit from not having to
consider execution logic that is several hundred lines long.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
