boy-uber opened a new pull request #29916:
URL: https://github.com/apache/spark/pull/29916


   ### What changes were proposed in this pull request?
   
   Spark has a hardcode list to contain known shuffle managers, which has two 
values now. It does not contain user's custom shuffle manager which is set 
through Spark config "spark.shuffle.manager".
   
   We hit issue when set "spark.shuffle.manager" with our own shuffle manager 
plugin (Uber Remote Shuffle Service implementation, 
https://github.com/uber/RemoteShuffleService). Other users will hit same issue 
when they implement their own shuffle manager.
   
   Need to add "spark.shuffle.manager" config value to the known managers list 
as well.
   
   ### Why are the changes needed?
   
   Spark has shuffle manager API to support custom shuffle manager 
implementation. The hardcoded known managers list does not consider that 
shuffle manager config value which could be set by user. Thus need to include 
that config value to known managers.
   
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   ### How was this patch tested?
   Current Spark unit test already covers the code path.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to