maropu commented on a change in pull request #28991:
URL: https://github.com/apache/spark/pull/28991#discussion_r498812040
##########
File path:
sql/hive-thriftserver/v2.3/src/main/java/org/apache/hive/service/cli/operation/OperationManager.java
##########
@@ -86,20 +86,15 @@ private void initOperationLogCapture(String loggingMode) {
}
public ExecuteStatementOperation newExecuteStatementOperation(HiveSession
parentSession,
Review comment:
I addressed you comment in #29933, so could you check it here?
##########
File path:
sql/hive-thriftserver/v1.2/src/main/java/org/apache/hive/service/cli/operation/OperationManager.java
##########
@@ -87,7 +87,7 @@ private void initOperationLogCapture(String loggingMode) {
}
public ExecuteStatementOperation newExecuteStatementOperation(HiveSession
parentSession,
- String statement, Map<String, String> confOverlay, boolean runAsync)
+ String statement, Map<String, String> confOverlay, boolean runAsync,
long queryTimeout)
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
