maropu commented on a change in pull request #28991:
URL: https://github.com/apache/spark/pull/28991#discussion_r499152313
##########
File path:
sql/hive-thriftserver/v1.2/src/main/java/org/apache/hive/service/cli/operation/OperationManager.java
##########
@@ -87,7 +87,7 @@ private void initOperationLogCapture(String loggingMode) {
}
public ExecuteStatementOperation newExecuteStatementOperation(HiveSession
parentSession,
- String statement, Map<String, String> confOverlay, boolean runAsync)
+ String statement, Map<String, String> confOverlay, boolean runAsync,
long queryTimeout)
Review comment:
This update is needed to add the `queryTimeout` param in
`SparkSQLOperationManager#newExecuteStatementOperation`:
https://github.com/apache/spark/pull/28991/files#diff-9d2cd65aaeae992250b5f40d8c289287R48
Looked around the related code and I think the current one is the simplest.
If you have better idea or another suggestion, please let me know in #29933.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
