zero323 commented on pull request #29879: URL: https://github.com/apache/spark/pull/29879#issuecomment-704085534
> Should we remove `python/join.pyi`, I considered that but overall I'd prefer to keep it as-is: - It is exposed to end user through RDD joins, but can be used directly (kind of useful, back when we still supported Python 2, not so much in 3, where we can use methods, without any caveats). - It is stable, have useful annotations and nothing indicates it's non-public character. > `python/rddsampler.pyi` I don't have strong opinion about it. However, same as join, it is stable with meaningful annotations and never marked as internal (I used it once or twice directly, so I suspect that others might as well). So indicates that it will cause serious maintenance overhead or is just a deadweight. > and `python/shell.pyi` too? Yes, that's an omission. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
