maropu commented on a change in pull request #29964:
URL: https://github.com/apache/spark/pull/29964#discussion_r500946426
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/ConnectionProvider.scala
##########
@@ -22,12 +22,15 @@ import java.util.ServiceLoader
import scala.collection.mutable
+import org.apache.spark.{SparkConf, SparkEnv}
import org.apache.spark.internal.Logging
import org.apache.spark.security.SecurityConfigurationLock
import org.apache.spark.sql.jdbc.JdbcConnectionProvider
import org.apache.spark.util.Utils
private[jdbc] object ConnectionProvider extends Logging {
+ private val providerEnabledConfig =
"spark.security.jdbc.connection.provider.%s.enabled"
Review comment:
Why didn't you put this config in `SQLConfig`? We assume users don't
care about it? I read the PR description and I thought first we would add a
config like `spark.sql.sources.useV1SourceList`;
```
For example;
val USE_JDBC_CONN_PROVIDER_LIST =
buildConf("spark.sql.sources.useJdbcConnProviderList")
.internal()
.doc("...")
.version("3.1.0")
.stringConf
.createWithDefault("db2,mysql,postgresql,...")
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
