HyukjinKwon commented on a change in pull request #29964:
URL: https://github.com/apache/spark/pull/29964#discussion_r500959911
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/ConnectionProvider.scala
##########
@@ -22,12 +22,15 @@ import java.util.ServiceLoader
import scala.collection.mutable
+import org.apache.spark.{SparkConf, SparkEnv}
import org.apache.spark.internal.Logging
import org.apache.spark.security.SecurityConfigurationLock
import org.apache.spark.sql.jdbc.JdbcConnectionProvider
import org.apache.spark.util.Utils
private[jdbc] object ConnectionProvider extends Logging {
+ private val providerEnabledConfig =
"spark.security.jdbc.connection.provider.%s.enabled"
Review comment:
This kind of pattern `provider.{providerName}.enabled` is used often in
other non-SQL codebase e.g.) `"spark.security.credentials.%s.enabled"` at
`HadoopDelegationTokenManager`. I think he's more used to this kind of pattern.
Since we're in SQL, maybe it's better to stick to the suggestion above if
possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
