dongjoon-hyun commented on a change in pull request #29961:
URL: https://github.com/apache/spark/pull/29961#discussion_r501205733
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcSourceSuite.scala
##########
@@ -581,7 +580,7 @@ class OrcSourceSuite extends OrcSuite with
SharedSparkSession {
}
test("Enforce direct encoding column-wise selectively") {
- testSelectiveDictionaryEncoding(isSelective = true)
+ testSelectiveDictionaryEncoding(isSelective = true, isHive23 = false)
Review comment:
After that, [[SPARK-27402][SQL][TEST-HADOOP3.2][TEST-MAVEN] Fix
hadoop-3.2 test issue(except the hive-thriftserver
module](https://github.com/apache/spark/commit/f3ddd6f9da27925607c06e55cdfb9a809633238b#diff-c0ffc4377a037f2e6def9779d0ec2527R121
) changed like the following.
```scala
- protected def testSelectiveDictionaryEncoding(isSelective: Boolean) {
+ protected def testSelectiveDictionaryEncoding(isSelective: Boolean,
isHive23: Boolean = false) {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
