dongjoon-hyun commented on a change in pull request #29961:
URL: https://github.com/apache/spark/pull/29961#discussion_r501206877



##########
File path: 
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcSourceSuite.scala
##########
@@ -581,7 +580,7 @@ class OrcSourceSuite extends OrcSuite with 
SharedSparkSession {
   }
 
   test("Enforce direct encoding column-wise selectively") {
-    testSelectiveDictionaryEncoding(isSelective = true)
+    testSelectiveDictionaryEncoding(isSelective = true, isHive23 = false)

Review comment:
       Initially, SPARK-27402 seems to use `isHive23` misleadingly because 
`isHive23=false` means Apache ORC in `sql/core` module and Hive 1.2.1 fork in 
`sql/hive` module.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to