Victsm commented on a change in pull request #29855:
URL: https://github.com/apache/spark/pull/29855#discussion_r503108862



##########
File path: 
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalBlockHandler.java
##########
@@ -89,6 +110,21 @@ public void receive(TransportClient client, ByteBuffer 
message, RpcResponseCallb
     handleMessage(msgObj, client, callback);
   }
 
+  @Override
+  public StreamCallbackWithID receiveStream(

Review comment:
       This is from the API introduced in SPARK-6237.
   That API was used for transferring large RDD partition blocks (>2GB), and we 
reused it for transferring shuffle partition blocks.
   Prefer to keep this API's name generic in case there are other use cases 
that could reuse this as well.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to