Victsm commented on a change in pull request #29855:
URL: https://github.com/apache/spark/pull/29855#discussion_r503114602
##########
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalBlockStoreClient.java
##########
@@ -116,6 +121,42 @@ public void fetchBlocks(
}
}
+ @Override
+ public void pushBlocks(
+ String host,
+ int port,
+ String[] blockIds,
+ ManagedBuffer[] buffers,
+ BlockFetchingListener listener) {
+ checkInit();
+ assert blockIds.length == buffers.length : "Number of block ids and
buffers do not match.";
+
+ Map<String, ManagedBuffer> buffersWithId = new HashMap<>();
+ for (int i = 0; i < blockIds.length; i++) {
+ buffersWithId.put(blockIds[i], buffers[i]);
+ }
+ logger.debug("Push {} shuffle blocks to {}:{}", blockIds.length, host,
port);
+ try {
+ RetryingBlockFetcher.BlockFetchStarter blockPushStarter =
+ (blockIds1, listener1) -> {
+ TransportClient client = clientFactory.createClient(host, port);
+ new OneForOneBlockPusher(client, appId, blockIds1, listener1,
buffersWithId).start();
+ };
+ int maxRetries = conf.maxIORetries();
+ if (maxRetries > 0) {
+ new RetryingBlockFetcher(
+ conf, blockPushStarter, blockIds, listener,
PUSH_ERROR_HANDLER).start();
+ } else {
+ blockPushStarter.createAndStart(blockIds, listener);
Review comment:
This follows the way it is done in the `fetchBlocks` API.
Should we remove it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
