bogdanghit commented on a change in pull request #29933:
URL: https://github.com/apache/spark/pull/29933#discussion_r503900908
##########
File path:
sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/operation/OperationManager.java
##########
@@ -86,20 +86,15 @@ private void initOperationLogCapture(String loggingMode) {
}
public ExecuteStatementOperation newExecuteStatementOperation(HiveSession
parentSession,
- String statement, Map<String, String> confOverlay, boolean runAsync)
- throws HiveSQLException {
- ExecuteStatementOperation executeStatementOperation =
ExecuteStatementOperation
- .newExecuteStatementOperation(parentSession, statement, confOverlay,
runAsync, 0);
+ String statement, Map<String, String> confOverlay, boolean runAsync,
long queryTimeout)
+ throws HiveSQLException {
+ ExecuteStatementOperation executeStatementOperation =
+ ExecuteStatementOperation.newExecuteStatementOperation(parentSession,
statement,
+ confOverlay, runAsync, queryTimeout);
addOperation(executeStatementOperation);
return executeStatementOperation;
}
- public ExecuteStatementOperation newExecuteStatementOperation(HiveSession
parentSession,
- String statement, Map<String, String> confOverlay, boolean runAsync,
long queryTimeout)
- throws HiveSQLException {
- return newExecuteStatementOperation(parentSession, statement, confOverlay,
runAsync);
- }
-
Review comment:
Can we just fix this to pass `queryTimeout` and also keep the method
without the extra parameter which passes through timeout 0?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
