bogdanghit commented on a change in pull request #29933:
URL: https://github.com/apache/spark/pull/29933#discussion_r503904107
##########
File path:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala
##########
@@ -45,11 +45,18 @@ private[hive] class SparkExecuteStatementOperation(
parentSession: HiveSession,
statement: String,
confOverlay: JMap[String, String],
- runInBackground: Boolean = true)
+ runInBackground: Boolean = true,
+ queryTimeout: Long)
extends ExecuteStatementOperation(parentSession, statement, confOverlay,
runInBackground)
with SparkOperation
with Logging {
+ private val queryTimeoutValue = if (queryTimeout <= 0) {
+ sqlContext.conf.getConf(SQLConf.THRIFTSERVER_QUERY_TIMEOUT)
+ } else {
+ queryTimeout
+ }
+
Review comment:
I don't understand this. If the passed queryTimeout value is <= 0 why
would we enforce the server-side configuration? And what is the relationship
with setting `java.sql.Statement.setQueryTimeout`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
