HeartSaVioR commented on a change in pull request #30033:
URL: https://github.com/apache/spark/pull/30033#discussion_r504403294
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala
##########
@@ -45,7 +45,7 @@ trait V2WriteCommand extends Command {
case (inAttr, outAttr) =>
// names and types must match, nullability must be compatible
inAttr.name == outAttr.name &&
- DataType.equalsIgnoreCompatibleNullability(outAttr.dataType,
inAttr.dataType) &&
+ DataType.equalsIgnoreCompatibleNullability(inAttr.dataType,
outAttr.dataType) &&
Review comment:
The usage of AppendData is reverted in
https://github.com/apache/spark/commit/b6e4aca0be7f3b863c326063a3c02aa8a1c266a3
for branch-2.4 and shipped to Spark 2.4.0. So while the code in AppendData for
branch-2.4 is broken as well, it's a dead code.
We seem to have three options: 1) revert remaining part of AppendData in
branch-2.4 2) fix the code but leave it as dead 3) leave it as it is. What's
our preference?
cc. @cloud-fan @HyukjinKwon
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
