Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-91324619
@adrian-wang This is a really helpful improvement! Besides my comments in
the code, I have two general comments. First, for this PR, it is fine to add
unnecessary `Exchange`s for now. We need to really make sure that we do not
miss `Exchange`s because the results will be wrong. I think it is necessary to
add tests in `DistributionSuite` for the added distribution and partitioning.
Second, I think it is necessary to test the correctness of the query results.
It will be really helpful for every tests for `ShuffledHashJoin`, we also test
the query with `SortMergeJoin`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
