Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/5208#discussion_r28103653
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala ---
@@ -178,6 +179,7 @@ class StatisticsSuite extends QueryTest with
BeforeAndAfterAll {
sql(s"""SET ${SQLConf.AUTO_BROADCASTJOIN_THRESHOLD}=$tmp""")
}
+ conf.setConf("spark.sql.autoSortMergeJoin", "true")
--- End diff --
I agree that we should add more unit test for sort merge join in
`JoinSuite`, just be sure we generate the right physical plans.
In the meantime, for correctness testing, we can add an new class which
extends the `HiveCompatibilitySuite`, and just set the
`spark.sql.autoSortMergeJoin` as `true` `false` in `beforeAll` and `afterAll`
respectively.
What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
