Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5350#discussion_r28019272
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SpecificMutableRow.scala
 ---
    @@ -230,13 +251,19 @@ final class SpecificMutableRow(val values: 
Array[MutableValue]) extends MutableR
         new GenericRow(newValues)
       }
     
    -  override def update(ordinal: Int, value: Any): Unit = {
    -    if (value == null) setNullAt(ordinal) else 
values(ordinal).update(value)
    +  override def update(ordinal: Int, value: Any) {
    +    if (value == null) {
    +      setNullAt(ordinal)
    +    } else {
    +      // for tests
    +      assert(!value.isInstanceOf[String], "String should be converted into 
UTF8String")
    +      values(ordinal).update(value)
    +    }
       }
     
    -  override def setString(ordinal: Int, value: String): Unit = 
update(ordinal, value)
    +  override def setString(ordinal: Int, value: String): Unit = 
update(ordinal, UTF8String(value))
    --- End diff --
    
    This is public API, so we can not change it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to