Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5350#discussion_r28019159
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SpecificMutableRow.scala
 ---
    @@ -202,6 +221,8 @@ final class SpecificMutableRow(val values: 
Array[MutableValue]) extends MutableR
             case DoubleType => new MutableDouble
             case BooleanType => new MutableBoolean
             case LongType => new MutableLong
    +        // TODO(davies): enable this
    +        // case StringType => new MutableString
    --- End diff --
    
    We need more thinking about reuse the UTF8String object, it's not a trivial 
decision, so I'd like to leave this out of this PR.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to