Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5438#discussion_r28053037
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/dstream/FileInputDStream.scala
---
@@ -331,11 +331,13 @@ private[streaming]
object FileInputDStream {
/**
- * Minimum duration of remembering the information of selected files.
Files with mod times
- * older than this "window" of remembering will be ignored. So if new
files are visible
- * within this window, then the file will get selected in the next batch.
+ * Minimum duration of remembering the information of selected files.
Defaults to 1 minute.
+ *
+ * Files with mod times older than this "window" of remembering will be
ignored. So if new
+ * files are visible within this window, then the file will get selected
in the next batch.
*/
- private val MIN_REMEMBER_DURATION = Minutes(1)
+ private val minRememberDuration = new
SparkConf().get("spark.streaming.minRememberDuration", "1")
--- End diff --
Note https://issues.apache.org/jira/browse/SPARK-5931 here which would
update time properties to be specifiable like "3s". It isn't updating property
names, but we could update a new one. I suggest this property name include the
units.
It looks like it's minutes here, so
`spark.streaming.minRememberDurationMin`. Can it be seconds to allow finer
granularity or is that unreasonable?
Why two fields here? just one `minRememberDurationMin` (or `Sec`) is needed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
