Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5438#discussion_r28055053
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/dstream/FileInputDStream.scala
---
@@ -331,19 +331,22 @@ private[streaming]
object FileInputDStream {
/**
- * Minimum duration of remembering the information of selected files.
Files with mod times
- * older than this "window" of remembering will be ignored. So if new
files are visible
- * within this window, then the file will get selected in the next batch.
+ * Minimum duration of remembering the information of selected files.
Defaults to 1 minute.
+ *
+ * Files with mod times older than this "window" of remembering will be
ignored. So if new
+ * files are visible within this window, then the file will get selected
in the next batch.
*/
- private val MIN_REMEMBER_DURATION = Minutes(1)
+ private val minRememberDurationMin = Minutes(new SparkConf()
--- End diff --
This much looks better, though now I also see that we need a real
`SparkConf` here somehow. I don't think this is a global, static property of
the object anymore. I think this would have to live in the `FileInputDStream`
class now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]