Github user nyaapa commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5424#discussion_r28058360
  
    --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
    @@ -845,6 +852,13 @@ private[spark] object Utils extends Logging {
         customHostname.getOrElse(localIpAddressHostname)
       }
     
    +  /**
    +   * Get the local machine's URI.
    +   */
    +  def localHostURI(): String = {
    --- End diff --
    
    I don't understand how to use "URI safe" name, something like 
```localHostNameURISafe``` or what?
    It's good to format URIs only in places where we need it, but currently we 
have more than one bug because of it.
    However we can use something like  
```InetAddresses.toUriString(InetAddress.getByName(Utils.localHostName()))``` 
to get URI in place without fixing Utils module, but i think that special URI 
method may prevent URI-based bugs in future due to its existence.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to