Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5424#discussion_r28055295
  
    --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
    @@ -845,6 +852,13 @@ private[spark] object Utils extends Logging {
         customHostname.getOrElse(localIpAddressHostname)
       }
     
    +  /**
    +   * Get the local machine's URI.
    +   */
    +  def localHostURI(): String = {
    --- End diff --
    
    Got it. I'm wondering when you _wouldn't_ want to use the "URI safe" name? 
they're identical in almost every case. Hm. I suppose the safer thing is to 
only format for URIs where, well, creating URIs. I'll have to dig into this 
more but generally want to minimize the change here and narrowly address the 
formatting issue


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to