viirya commented on a change in pull request #30093:
URL: https://github.com/apache/spark/pull/30093#discussion_r508160798
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##########
@@ -1056,8 +1058,14 @@ object EliminateSorts extends Rule[LogicalPlan] {
case s @ Sort(orders, _, child) if orders.isEmpty ||
orders.exists(_.child.foldable) =>
val newOrders = orders.filterNot(_.child.foldable)
if (newOrders.isEmpty) child else s.copy(order = newOrders)
- case Sort(orders, true, child) if
SortOrder.orderingSatisfies(child.outputOrdering, orders) =>
- child
+ case s @ Sort(orders, global, child)
+ if SortOrder.orderingSatisfies(child.outputOrdering, orders) =>
+ (global, child) match {
+ case (false, _) => child
+ case (true, r: Range) => r
Review comment:
This assumes we know Range's global ordering in advance. This seems to
leak physical stuff into the Optimizer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
