maropu commented on a change in pull request #30093:
URL: https://github.com/apache/spark/pull/30093#discussion_r508280122
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/EliminateSortsSuite.scala
##########
@@ -97,14 +97,22 @@ class EliminateSortsSuite extends PlanTest {
comparePlans(optimized, correctAnswer)
}
- test("remove redundant order by") {
+ test("remove redundant local sort") {
val orderedPlan = testRelation.select('a, 'b).orderBy('a.asc,
'b.desc_nullsFirst)
- val unnecessaryReordered = orderedPlan.limit(2).select('a).orderBy('a.asc,
'b.desc_nullsFirst)
+ val unnecessaryReordered = orderedPlan.limit(2).select('a).sortBy('a.asc,
'b.desc_nullsFirst)
val optimized = Optimize.execute(unnecessaryReordered.analyze)
val correctAnswer = orderedPlan.limit(2).select('a).analyze
comparePlans(Optimize.execute(optimized), correctAnswer)
}
+ test("should not remove global sort") {
Review comment:
nit: Add a prefix: `SPARK-33183:` for all the added tests?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
