zero323 commented on a change in pull request #29122:
URL: https://github.com/apache/spark/pull/29122#discussion_r508823033
##########
File path: python/pyspark/sql/avro/functions.py
##########
@@ -26,7 +26,7 @@
@since(3.0)
-def from_avro(data, jsonFormatSchema, options={}):
+def from_avro(data, jsonFormatSchema, options=None):
Review comment:
We should change annotations from
```python
def from_avro(
data: ColumnOrName, jsonFormatSchema: str, options: Dict[str, str] = ...
) -> Column: ..
```
to
```python
def from_avro(
data: ColumnOrName, jsonFormatSchema: str, options: Optional[Dict[str,
str]] = ...
) -> Column: ..
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
