zero323 commented on a change in pull request #29122:
URL: https://github.com/apache/spark/pull/29122#discussion_r508868556
##########
File path: python/pyspark/sql/avro/functions.py
##########
@@ -26,7 +26,7 @@
@since(3.0)
-def from_avro(data, jsonFormatSchema, options={}):
+def from_avro(data, jsonFormatSchema, options=None):
Review comment:
> Mypy has been added, and I would expect that this would be caught.
As far as I recall this behavior depends on the MyPy flags. In particular
see [Disabling strict optional
checking](https://mypy.readthedocs.io/en/stable/kinds_of_types.html#no-strict-optional).
So adding `no_implicit_optional` to `mypy.ini` should catch this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
