Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5439#discussion_r28054428
--- Diff:
extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisUtils.scala
---
@@ -16,6 +16,7 @@
*/
package org.apache.spark.streaming.kinesis
+import com.amazonaws.auth.AWSCredentials
--- End diff --
Nit: space after import.
I know we have all lived to regret including third-party classes as part of
the API. Although it seems maybe essential here, I wonder if there is any
reasonable way to not accept this as `AWSCredentials` but as access keys or
something. I suppose that this could work but would assume a certain type of
credentials are being used.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
