Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5439#discussion_r28202950
--- Diff:
extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisUtils.scala
---
@@ -90,8 +93,9 @@ object KinesisUtils {
endpointUrl: String,
checkpointInterval: Duration,
initialPositionInStream: InitialPositionInStream,
- storageLevel: StorageLevel): JavaReceiverInputDStream[Array[Byte]] =
{
+ storageLevel: StorageLevel,
--- End diff --
Yes, the idea is not to change the API. I suppose this is less important as
a module, but still. I would have thought MiMa would flag this but I don't know
that it checks this module.
I think this is really something for @cfregly et al to review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
