jkleckner commented on pull request #29533: URL: https://github.com/apache/spark/pull/29533#issuecomment-715618903
> I tried this patch in production but it does not seem to work. > > ... > I'm not sure if I made a mistake or there's a problem in the patch. Thanks Your rebase of the patch looks correct when I tried it out. Unfortunately, there must be something in the patches to k8s code after 2.4 and before the fix #28423 was merged. My interest in landing this patch has been to unblock #29496 due to the backporting policies for Spark 2.4 which is what we use and I don't have a setup to test this for the 3.0 branch. @redsk if you would like to look into that, it would be helpful. The candidate patch sets that are in the k8s can be viewed with something like this: `git log --oneline branch-3.0..0432379f9923768a767566e9ac5a4021cfe8d052 -- resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s` ``` 0432379f99 [SPARK-24266][K8S] Restart the watcher when we receive a version changed from k8s c8f3bd861d [SPARK-31696][K8S] Support driver service annotation in K8S 85dad37f69 [SPARK-31601][K8S] Fix spark.kubernetes.executor.podNamePrefix to work b8ccd75524 [SPARK-29905][K8S] Improve pod lifecycle manager behavior with dynamic allocation 7699f765f5 [SPARK-31394][K8S] Adds support for Kubernetes NFS volume mounts ed06d98044 [SPARK-25355][K8S] Add proxy user to driver if present on spark-submit 1254c88034 [SPARK-31118][K8S][DOC] Add version information to the configuration of K8S d273a2bb0f [SPARK-20628][CORE][K8S] Start to improve Spark decommissioning & preemption support f9f06eee98 [SPARK-30122][K8S] Support spark.kubernetes.authenticate.executor.serviceAccountName 86fdb818bf [SPARK-30715][K8S] Bump fabric8 to 4.7.1 ``` @stijndehaes can you guide as to which of these might affect this backport? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
