cloud-fan commented on a change in pull request #30097:
URL: https://github.com/apache/spark/pull/30097#discussion_r512000413
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/AggregateOptimizeSuite.scala
##########
@@ -29,7 +29,8 @@ import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.sql.internal.SQLConf.{CASE_SENSITIVE, GROUP_BY_ORDINAL}
class AggregateOptimizeSuite extends PlanTest {
- override val conf = new SQLConf().copy(CASE_SENSITIVE -> false,
GROUP_BY_ORDINAL -> false)
+ SQLConf.get.setConf(CASE_SENSITIVE, false)
+ SQLConf.get.setConf(GROUP_BY_ORDINAL, false)
Review comment:
Can we follow
https://github.com/apache/spark/pull/30097/files#diff-6f79a980de03203104cfacc6f50c302b843e3b60f1d48942bded6706c75a02b7R128
, instead of updating the global conf object?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
