cloud-fan commented on a change in pull request #30097:
URL: https://github.com/apache/spark/pull/30097#discussion_r512008197
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/sources/DataSourceAnalysisSuite.scala
##########
@@ -196,6 +202,7 @@ class DataSourceAnalysisSuite extends SparkFunSuite with
BeforeAndAfterAll {
}
test(s"Static partition and dynamic partition (caseSensitive:
$caseSensitive)") {
+ SQLConf.get.setConf(SQLConf.CASE_SENSITIVE, caseSensitive)
Review comment:
I have a better idea. We can create a `test` method in this suite:
```
def test(caseSensitive: Boolean, testName: String)(func: => Unit) = {
test(s"$testName (caseSensitive: $caseSensitive)") {
withSQLConf(case sen....) {
func
}
}
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
