Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5208#discussion_r28198847
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala ---
    @@ -177,6 +183,7 @@ private[sql] trait LeafNode extends SparkPlan with 
trees.LeafNode[SparkPlan] {
     private[sql] trait UnaryNode extends SparkPlan with 
trees.UnaryNode[SparkPlan] {
       self: Product =>
       override def outputPartitioning: Partitioning = child.outputPartitioning
    +  override def outputOrdering: Seq[SortOrder] = child.outputOrdering
    --- End diff --
    
    Oh I see.  I tend to think we might want to be explicit with sort order.  
Many unary nodes change it.  Even for project, the order is only valid if the 
columns are still present.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to