Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/5445#discussion_r28199718
--- Diff: python/pyspark/sql/types.py ---
@@ -997,12 +997,13 @@ def _restore_object(dataType, obj):
# same object in most cases.
k = id(dataType)
cls = _cached_cls.get(k)
- if cls is None:
+ if cls is None or cls.__datatype is not dataType:
--- End diff --
Yes, there is a side effect that the id of dataType will be not recycled
once we keep a reference of it in `cls`.
In the beginning, I thought the check is helping, actually, it's not. We
can change it to an assert, or remove it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
