Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5445#discussion_r28200072
--- Diff: python/pyspark/sql/types.py ---
@@ -1119,8 +1120,8 @@ def Dict(d):
class Row(tuple):
""" Row in DataFrame """
- __DATATYPE__ = dataType
- __FIELDS__ = tuple(f.name for f in dataType.fields)
+ __datatype = dataType
--- End diff --
It looks like `Row` held a reference to its `DataType` even in the old
code, so I guess the only new references here are the ones that we're adding to
the functions / arrays / etc. returned from the other branches of
`_create_cls`. I suppose that we could set those objects' `__dataType__`
fields inside of the `_create_cls` function instead of setting them in
`_restore_object` if you think that would be easier to understand. Not a huge
deal to set it outside, though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
