HeartSaVioR commented on a change in pull request #30203: URL: https://github.com/apache/spark/pull/30203#discussion_r517144041
########## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/python/ExtractPythonUDFs.scala ########## @@ -218,13 +218,22 @@ object ExtractPythonUDFs extends Rule[LogicalPlan] with PredicateHelper { } } + private def canonicalizeDeterministic(u: PythonUDF) = { Review comment: I agree that is orthogonal and isn't a blocker for this PR. Would we like to move the discussion further on dev@ mailing list, or it sounds like we are happy with filing a new JIRA issue and raising a PR to change the default? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org