Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5438#discussion_r28232809
  
    --- Diff: 
streaming/src/main/scala/org/apache/spark/streaming/dstream/FileInputDStream.scala
 ---
    @@ -80,6 +80,15 @@ class FileInputDStream[K, V, F <: NewInputFormat[K,V]](
     
       private val serializableConfOpt = conf.map(new SerializableWritable(_))
     
    +  /**
    +   * Minimum duration of remembering the information of selected files. 
Defaults to 1 minute.
    +   *
    +   * Files with mod times older than this "window" of remembering will be 
ignored. So if new
    +   * files are visible within this window, then the file will get selected 
in the next batch.
    +   */
    +  private val minRememberDurationMin = Minutes(ssc.conf
    --- End diff --
    
    The continuation indent looks a bit off here. Maybe just start the next 
line with `Minutes(...`.
    I think we might want to put this change on hold until SPARK-5931 is 
resolved, since it will give some proper syntax for time-based properties that 
you can use here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to