cloud-fan commented on a change in pull request #29339:
URL: https://github.com/apache/spark/pull/29339#discussion_r519936908
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -3415,10 +3415,10 @@ class AstBuilder(conf: SQLConf) extends
SqlBaseBaseVisitor[AnyRef] with Logging
val specsAndLocs = ctx.partitionSpecLocation.asScala.map { splCtx =>
val spec = visitNonOptionalPartitionSpec(splCtx.partitionSpec)
val location = Option(splCtx.locationSpec).map(visitLocationSpec)
- spec -> location
+ UnresolvedPartitionSpec(spec, location)
}
- AlterTableAddPartitionStatement(
- visitMultipartIdentifier(ctx.multipartIdentifier),
+ AlterTableAddPartition(
+ UnresolvedTableOrView(visitMultipartIdentifier(ctx.multipartIdentifier)),
Review comment:
We shouldn't change behavior in this PR. If `AlterTableAddPartition`
fails before if the name refers to a view, we should use `UnresolvedTable` to
keep the failing behavior.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
