cloud-fan commented on a change in pull request #29339:
URL: https://github.com/apache/spark/pull/29339#discussion_r519948064
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala
##########
@@ -2066,13 +2069,68 @@ class DataSourceV2SQLSuite
}
test("ALTER TABLE ADD PARTITION") {
- val t = "testcat.ns1.ns2.tbl"
+ val t = "testpart.ns1.ns2.tbl"
withTable(t) {
spark.sql(s"CREATE TABLE $t (id bigint, data string) USING foo
PARTITIONED BY (id)")
- val e = intercept[AnalysisException] {
- sql(s"ALTER TABLE $t ADD PARTITION (id=1) LOCATION 'loc'")
- }
- assert(e.message.contains("ALTER TABLE ADD PARTITION is only supported
with v1 tables"))
+ spark.sql(s"ALTER TABLE $t ADD PARTITION (id=1) LOCATION 'loc'")
+
+ val partTable = catalog("testpart").asTableCatalog
+ .loadTable(Identifier.of(Array("ns1", "ns2"),
"tbl")).asInstanceOf[InMemoryPartitionTable]
+ assert(partTable.partitionExists(InternalRow.fromSeq(Seq(1))))
+
+ val partMetadata =
partTable.loadPartitionMetadata(InternalRow.fromSeq(Seq(1)))
+ assert(partMetadata.containsKey("location"))
+ assert(partMetadata.get("location") == "loc")
+
+ partTable.clearPartitions()
Review comment:
Can we remove it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
