cloud-fan commented on a change in pull request #30332:
URL: https://github.com/apache/spark/pull/30332#discussion_r521834964
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/SparkSqlParserSuite.scala
##########
@@ -70,9 +70,21 @@ class SparkSqlParserSuite extends AnalysisTest {
StaticSQLConf
ConfigEntry.knownConfigs.values.asScala.foreach { config =>
assertEqual(s"SET ${config.key}", SetCommand(Some(config.key -> None)))
- if (config.defaultValue.isDefined && config.defaultValueString != null) {
- assertEqual(s"SET ${config.key}=${config.defaultValueString}",
Review comment:
I think this test is to make sure we don't need to quote for builtin
config keys and values.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
