viirya commented on a change in pull request #30332:
URL: https://github.com/apache/spark/pull/30332#discussion_r521841476
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala
##########
@@ -79,18 +80,32 @@ class SparkSqlAstBuilder(conf: SQLConf) extends
AstBuilder(conf) {
case s if s.isEmpty =>
SetCommand(None)
case _ => throw new ParseException("Expected format is 'SET', 'SET key',
or " +
- "'SET key=value'. If you want to include special characters in key, " +
- "please use quotes, e.g., SET `ke y`=value.", ctx)
+ "'SET key=value'. If you want to include special characters in key, or
include semicolon " +
+ "in value, please use quotes, e.g., SET `ke y`=`v;alue`.", ctx)
}
}
- override def visitSetQuotedConfiguration(ctx: SetQuotedConfigurationContext)
- : LogicalPlan = withOrigin(ctx) {
- val keyStr = ctx.configKey().getText
- if (ctx.EQ() != null) {
- SetCommand(Some(keyStr -> Option(remainder(ctx.EQ().getSymbol).trim)))
+ override def visitSetQuotedConfiguration(
+ ctx: SetQuotedConfigurationContext): LogicalPlan = withOrigin(ctx) {
+ if (ctx.configValue() != null && ctx.configKey() != null) {
+ SetCommand(Some(ctx.configKey().getText ->
Option(ctx.configValue().getText)))
+ } else if (ctx.configValue() != null) {
+ interval(ctx.SET().getSymbol, ctx.EQ().getSymbol).trim match {
Review comment:
Add `val valueStr = ctx.configValue().getText` and use it like `keyStr`
below? It will easier to read.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
