otterc commented on a change in pull request #30139:
URL: https://github.com/apache/spark/pull/30139#discussion_r523353481
##########
File path:
common/network-common/src/main/java/org/apache/spark/network/server/ChunkFetchRequestHandler.java
##########
@@ -88,12 +88,14 @@ public void processFetchRequest(
logger.trace("Received req from {} to fetch block {}",
getRemoteAddress(channel),
msg.streamChunkId);
}
- long chunksBeingTransferred = streamManager.chunksBeingTransferred();
- if (chunksBeingTransferred >= maxChunksBeingTransferred) {
- logger.warn("The number of chunks being transferred {} is above {},
close the connection.",
- chunksBeingTransferred, maxChunksBeingTransferred);
- channel.close();
- return;
+ if (maxChunksBeingTransferred < Long.MAX_VALUE) {
+ long chunksBeingTransferred = streamManager.chunksBeingTransferred();
+ if (chunksBeingTransferred >= maxChunksBeingTransferred) {
+ logger.warn("The number of chunks being transferred {} is above {},
close the connection.",
+ chunksBeingTransferred, maxChunksBeingTransferred);
Review comment:
Nit: indentation should be 2
##########
File path:
common/network-common/src/main/java/org/apache/spark/network/server/TransportRequestHandler.java
##########
@@ -124,12 +124,14 @@ private void processStreamRequest(final StreamRequest
req) {
req.streamId);
}
- long chunksBeingTransferred = streamManager.chunksBeingTransferred();
- if (chunksBeingTransferred >= maxChunksBeingTransferred) {
- logger.warn("The number of chunks being transferred {} is above {},
close the connection.",
- chunksBeingTransferred, maxChunksBeingTransferred);
- channel.close();
- return;
+ if (maxChunksBeingTransferred < Long.MAX_VALUE) {
+ long chunksBeingTransferred = streamManager.chunksBeingTransferred();
+ if (chunksBeingTransferred >= maxChunksBeingTransferred) {
+ logger.warn("The number of chunks being transferred {} is above {},
close the connection.",
+ chunksBeingTransferred, maxChunksBeingTransferred);
Review comment:
Nit: indentation should be 2 spaces
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
