HeartSaVioR commented on pull request #30210: URL: https://github.com/apache/spark/pull/30210#issuecomment-727120756
I was writing a wall of text and Chrome happily (?) killed itself. Rewriting one. What I really asked you to do is exactly this. The practice is also happened for the first time I made a first contribution on Apache Spark. If you want I can find that too. https://github.com/apache/spark/pull/30139#issuecomment-727103124 I'm really unhappy now you're saying I'm framing Apache Spark community to be negative ways. I was never saying about the community here. Let me quote my comment again, where's the strong voice like the attacking or making things being negative, and mentioning any sort of thing representing community? > (I hope the PR can wait for reviewers' approvals who left valid review comments. I understand the PR can be merged "technically", but doesn't seem to be a good practice. If in doubt w.r.t reviewers being inactive, we can at least wait for a day based on timezone difference.) This comment is exactly explaining the same thing what I link for reference. Could you find any difference? Even I didn't say that strongly. A PMC member is just a "one of" PMC members. Before you make consensus along with PMC members and construct a BYLAWS, you can't frame me as one guy complaining to Spark community. The practice is not a thing "everyone" has a belief, so attacking the practice shouldn't be interpreted like so. Makes sense? For sure, I said about -1 as a sort of joke, but what you requested to me to block merger to merge at any time is "technically" the same. That is just a "representational" difference, and for me it's also not welcomed one if I have to always mention merger to stop doing before I approve. And this suggestion is your own, not from the consensus. But in overall, I have to admit I really did one bad thing, trying to educate someone which is not constructed like BYLAW in any way, regardless of the intention. I should avoid doing that and raise discussion in dev mailing thread like I have been doing before. My apologize. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
