cloud-fan commented on a change in pull request #30403:
URL: https://github.com/apache/spark/pull/30403#discussion_r525921999
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala
##########
@@ -441,19 +441,16 @@ class ResolveSessionCatalog(
ShowCreateTableCommand(ident.asTableIdentifier)
}
- case CacheTableStatement(tbl, plan, isLazy, options) =>
- val name = if (plan.isDefined) {
- // CACHE TABLE ... AS SELECT creates a temp view with the input query.
- // Temp view doesn't belong to any catalog and we shouldn't resolve
catalog in the name.
- tbl
- } else {
- parseTempViewOrV1Table(tbl, "CACHE TABLE")
- }
- CacheTableCommand(name.asTableIdentifier, plan, isLazy, options)
+ // CACHE TABLE ... AS SELECT creates a temp view with the input query.
+ // Thus, use the identifier in UnresolvedTableOrView directly,
+ case CacheTable(u: UnresolvedTableOrView, plan, isLazy, options) if
plan.isDefined =>
+ CacheTableCommand(u.multipartIdentifier.asTableIdentifier, plan, isLazy,
options)
Review comment:
This is more like CTAS and the `table` should be just `Seq[String]` not
`LogicalPlan`.
How about we have both `CacheTable(table: LogicalPlan, ...)` and
`CacheTabeAsSelect(tempViewName: String, ...)`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
