imback82 commented on a change in pull request #30403:
URL: https://github.com/apache/spark/pull/30403#discussion_r526049295
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala
##########
@@ -289,6 +289,12 @@ class DataSourceV2Strategy(session: SparkSession) extends
Strategy with Predicat
case ShowCreateTable(_: ResolvedTable, _) =>
throw new AnalysisException("SHOW CREATE TABLE is not supported for v2
tables.")
+ case CacheTable(_: ResolvedTable, _, _, _) =>
+ throw new AnalysisException("CACHE TABLE is not supported for v2
tables.")
Review comment:
Ah OK. An existing bug, I guess? (it only supported temp view / v1
tables).
Does it make sense to match `case CacheTable(_: ResolvedTable, _, _, _) ` in
`ResolveSessionCatalog` (seems weird) or should we match it in
`DataSourceV2Strategy` with a new `CacheTableExec` similar to
`CacheTableCommand`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
