Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/4602#discussion_r28373360
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Generate.scala ---
@@ -31,40 +31,29 @@ import org.apache.spark.sql.catalyst.expressions._
* it.
* @param outer when true, each input row will be output at least once,
even if the output of the
* given `generator` is empty. `outer` has no effect when
`join` is false.
+ * @param output the output attributes of this node, which constructed in
analysis phase,
+ * and we can not change it, as the parent node bound with
it already.
*/
@DeveloperApi
case class Generate(
generator: Generator,
join: Boolean,
outer: Boolean,
- child: SparkPlan)
+ child: SparkPlan,
+ output: Seq[Attribute])
--- End diff --
Make child last argument, get rid of default arguments above.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
