Github user chenghao-intel commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4602#discussion_r28575756
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala
 ---
    @@ -42,47 +42,27 @@ abstract class Generator extends Expression {
     
       override type EvaluatedType = TraversableOnce[Row]
     
    -  override lazy val dataType =
    -    ArrayType(StructType(output.map(a => StructField(a.name, a.dataType, 
a.nullable, a.metadata))))
    +  override def dataType: DataType = ???
    --- End diff --
    
    As we moved the output field names from the `Generator` to `Generate`, 
probably it's impossible to construct the `StructType` any more within the 
`Generator`. And, it will be the rare case to the `dataType` method of a 
`Generator`, how about keep throwing exception if people do that?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to