leanken commented on pull request #30560: URL: https://github.com/apache/spark/pull/30560#issuecomment-736348346
Why were 1. checkExceptionInExpression[Exception](expr, errMsg) 2. sql/testOnly org.apache.spark.sql.SQLQueryTestSuite – -z ansi/map.sql in SPARK-33460 can't detect this Bug It's because 1. checkExceptionInExpression is some how with error, too, but i don't know of the history. It should wrap with withSQLConf(SQLConf.CODEGEN_FACTORY_MODE.key like CheckEvalulation, AND WE SHOULD FIX this later. 2. SQLQueryTestSuite ansi/map.sql failed to detect because of the Constant Folding rules, it is calling eval instead of code gen in this case ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
